Slow calculation

Slow calculation - Messages

#1 Posted: 12/19/2023 11:55:54 PM
Fikret Atalay

Fikret Atalay

2 likes in 24 posts.

Group: User

Hi all, I am putting together a quick worksheet to calculate factor of safety against soil liquefaction triggering. As I have been going step-by-step and defining the various variables, I noticed that all the calculations take place more or less instantaneously, whereas the last variable I defined (N1_60cs) seems to take a relatively long time to calculate (approximately 12 seconds on my machine). The worksheet I have so far is attached.

Any thoughts as to what is causing this? Thanks in advance!

Seismic Site Class & Liquefaction Potential.sm (124 KiB) downloaded 56 time(s).
#2 Posted: 12/20/2023 12:50:59 AM
Davide Carpi

Davide Carpi

1417 likes in 2873 posts.

Group: Moderator

Hi,

select all > optimization > numeric

AND EITHER

z:z

z def z.png

OR

z:+line(...)

z plus.png


This is because z:line() is a procedure (something like a function, but for variables); it doesn't evaluates in place on definition, hence is completely calculated from scratch every time you need z, z[j], etc....
Using a + between the definition operator and the line() function, you don't have anymore a procedure; using z:z, it evaluates once from that point onwards.


Seismic Site Class & Liquefaction Potential_num.sm (124 KiB) downloaded 59 time(s).
If you like my plugins please consider to support the program buying a license; for personal contributions to me: paypal.me/dcprojects
#3 Posted: 12/20/2023 1:01:15 AM
Fikret Atalay

Fikret Atalay

2 likes in 24 posts.

Group: User

Perfect, that works!

Much appreciated as always!
#4 Posted: 12/20/2023 1:23:18 AM
Davide Carpi

Davide Carpi

1417 likes in 2873 posts.

Group: Moderator

You're welcome!
If you like my plugins please consider to support the program buying a license; for personal contributions to me: paypal.me/dcprojects
#5 Posted: 12/20/2023 1:30:22 AM
Jean Giraud

Jean Giraud

983 likes in 6866 posts.

Group: User

Your last for/loop, as given, takes 32 s
isolate the three components
a:=eval(a) , b:=eval(b) ...
timing drops 4 s
#6 Posted: 12/20/2023 2:07:23 AM
Alvaro Diaz Falconi

Alvaro Diaz Falconi

992 likes in 1675 posts.

Group: User

Hi. This is another option, without numeric optimizations. You don't need to use line in your calculations. As Davide says, that makes the calculations faster to SMath.

Seismic Site Class & Liquefaction Potential.sm (122 KiB) downloaded 51 time(s).


Bes regards.
Alvaro.
#7 Posted: 12/20/2023 3:15:47 AM
Fikret Atalay

Fikret Atalay

2 likes in 24 posts.

Group: User

Thank you, Alvaro! I like having the lines because it makes it clearer as to which parameter I am defining. I just didn't realize it was slowing it down so much (although putting + in front of the lines makes the problem go away - sort of a win-win!).

Thanks again.

Wrote

Hi. This is another option, without numeric optimizations. You don't need to use line in your calculations. As Davide says, that makes the calculations faster to SMath.

Seismic Site Class & Liquefaction Potential.sm (122 KiB) downloaded 51 time(s).


Bes regards.
Alvaro.



#8 Posted: 12/20/2023 3:16:36 AM
overlord

overlord

554 likes in 1333 posts.

Group: Moderator

Wrote

Hi. This is another option, without numeric optimizations. You don't need to use line in your calculations.


Another issue is, all calculation can be done under one for() loop.
If data matrices is much longer and not 10, this would benefit too.
However, the way it is written look much nicer and cleaner.
#9 Posted: 12/20/2023 12:07:29 PM
Alvaro Diaz Falconi

Alvaro Diaz Falconi

992 likes in 1675 posts.

Group: User

Wrote

I like having the lines because it makes it clearer as to which parameter I am defining.



Hi. You can eliminate all the for loops using the SMath index vectorization, which work more or less like the same concept in matlab, with cases() for having some visual separation

Clipboard01.png

Seismic Site Class & Liquefaction Potential v2.sm (119 KiB) downloaded 58 time(s).

Best regards.
Alvaro.
  • New Posts New Posts
  • No New Posts No New Posts